react-native-fetch-blob replaced with rn-fetch-blob #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich crash app in production updated some dependencies, including switching unmaintained react-native-fetch-blob to rn-fetch-blob - fixes kfiroo#122, kfiroo#121
|
@kfiroo are you still here? |
|
Note that to use my fork (fungilation/), change native installation in your own app to I'm using in my app WonderSwipe without issue. |
|
thanks @fungilation!, already using, no issues. |
|
@kfiroo can this be merged please |
yarn upgraded, then nuked /node_modules (again) - dependencies only (not devDependencies, like RN) - not nuking /node_modules results in clash in Metro: Loading dependency graph...(node:3868) UnhandledPromiseRejectionWarning: Error: jest-haste-map: @providesModule naming collision: Duplicate module name: react-native
…community/react-native-netinfo Need to run in installed app: react-native link @react-native-community/netinfo
|
On topic of maintenance and forking: #160 |
Update package.json
- removed redundant `errorMessage.includes("folder")`
- prettier formatted fsUtils.js
and #3-5 updating netinfo
* Rename deprecated methods to suppress warnings (for now) * Mark CachedImage as unsafe as well * well don't stop there, completed search and replace for UNSAFE_componentWillMount
* fix: Change @react-native-community/net-info to a peer dependency * Typo * in the same vein, rn-fetch-blob also moved to peerDependencies. But that also means for apps (like mine) with no otherwise dependency on @react-native-community/netinfo and rn-fetch-blob, they would be removed fron npm. Added the 2 to npm / yarn install instructions in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promise.reject() instead of throw new Error(), at places which crash app in production
updated some dependencies, including switching unmaintained react-native-fetch-blob to rn-fetch-blob