New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: on commit format changed files with prettier #9128
chore: on commit format changed files with prettier #9128
Conversation
2385280
to
10701bf
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 61d8db8:
|
10701bf
to
0e19844
Compare
94e1567
to
8d18a1d
Compare
@@ -16,7 +16,7 @@ | |||
"test:debug": "node --inspect-brk ./node_modules/.bin/jest", | |||
"test:admin-ui": "jest tests/admin-ui-tests", | |||
"build": "preconstruct build", | |||
"prepare": "preconstruct dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am personally against using husky
or anything that hooks into my git workflows
"singleQuote": true, | ||
"semi": false, | ||
"printWidth": 100 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will opt for the configuration we used in #8910
Superceded by #9144, but thanks @iamandrewluca for pushing this forward, as I know many contributors have been asking about the lack of any rules |
It needs to be clarified which format style guide to use in the project.
I added the prettier format for only changed files using the default config.
I did not run prettier on the entire project, as there are a lot of files (over 1k) to be changed.
Did some tests and changed a little default prettier config, to match more the formatting of current source code.