Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing bcrypt-nodejs to bcrypt #4998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changing bcrypt-nodejs to bcrypt #4998

wants to merge 1 commit into from

Conversation

parse-hardik
Copy link

@parse-hardik parse-hardik commented Nov 8, 2020 •
edited

Description of changes

Since the package bcrypt-nodejs has been deprecated, all occurences of the package have been replaced by bcrypt package.

Related issues (if any)

Testing

  • [ No UI changes were made ] List browser version(s) any admin UI changes were tested in:
  • [ Yes ] Please confirm you've added (or verified) test coverage for this change.
  • [ Yes ] Please confirm npm run test-all ran successfully.

@JedWatson Can you please review the PR

@parse-hardik parse-hardik marked this pull request as draft November 8, 2020 11:35
@parse-hardik parse-hardik marked this pull request as ready for review November 8, 2020 11:36
@parse-hardik parse-hardik marked this pull request as draft November 8, 2020 11:36
@parse-hardik parse-hardik marked this pull request as ready for review November 8, 2020 11:41
@parse-hardik
Copy link
Author

I shall add reviewers.

@parse-hardik parse-hardik reopened this Nov 8, 2020
@parse-hardik parse-hardik marked this pull request as draft November 8, 2020 14:13
@parse-hardik parse-hardik marked this pull request as ready for review November 8, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@parse-hardik