Merge pull request #4397 from jyrkive/required-number-with-default

Fix: model with required field that defaults to 0 can't be saved
keystonejs · Jan 22, 2018 · ce14c51 · ce14c51
2 parents eb7ef63 + 12de7af
commit ce14c51
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fields/types/boolean/BooleanType.js b/fields/types/boolean/BooleanType.js
@@ -36,7 +36,7 @@ boolean.prototype.validateInput = function (data, callback) {
 
 boolean.prototype.validateRequiredInput = function (item, data, callback) {
 	var value = this.getValueFromData(data);
-	var result = (value && value !== 'false') || item.get(this.path) ? true : false;
+	var result = (value && value !== 'false') || typeof item.get(this.path) === 'boolean' ? true : false;
 	utils.defer(callback, result);
 };
 

diff --git a/fields/types/number/NumberType.js b/fields/types/number/NumberType.js
@@ -39,7 +39,7 @@ number.prototype.validateInput = function (data, callback) {
 number.prototype.validateRequiredInput = function (item, data, callback) {
 	var value = this.getValueFromData(data);
 	var result = !!(value || typeof value === 'number');
-	if (value === undefined && item.get(this.path)) {
+	if (value === undefined && typeof item.get(this.path) === 'number') {
 		result = true;
 	}
 	utils.defer(callback, result);