Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some comments #26638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some comments #26638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/auth/credential_authority.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func NewCredentialAuthority(log logger.Logger, api UserKeyAPIer) *CredentialAuth
return newCredentialAuthorityWithEngine(log, api, newStandardEngine())
}

// newCredentialAuthoirutyWithEngine is an internal call that can specify the non-standard
// newCredentialAuthorityWithEngine is an internal call that can specify the non-standard
// engine. We'd only need to call this directly from testing to specify a testingEngine.
func newCredentialAuthorityWithEngine(log logger.Logger, api UserKeyAPIer, eng engine) *CredentialAuthority {
ret := &CredentialAuthority{
Expand Down
2 changes: 1 addition & 1 deletion go/chat/s3/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func (b *Bucket) GetResponse(ctx context.Context, path string) (resp *http.Respo
return b.GetResponseWithHeaders(ctx, path, make(http.Header))
}

// GetReaderWithHeaders retrieves an object from an S3 bucket
// GetResponseWithHeaders retrieves an object from an S3 bucket
// Accepts custom headers to be sent as the second parameter
// returning the body of the HTTP response.
// It is the caller's responsibility to call Close on rc when
Expand Down
2 changes: 1 addition & 1 deletion go/client/commands_nix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func restartLaunchdService(g *libkb.GlobalContext, label string, serviceInfoPath
return fmt.Errorf("Unsupported on this platform")
}

// DebugSocketError allows platforms to help the user diagnose and resolve
// DiagnoseSocketError allows platforms to help the user diagnose and resolve
// socket errors.
func DiagnoseSocketError(ui libkb.UI, err error) {}

Expand Down
2 changes: 1 addition & 1 deletion go/client/commands_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ func restartLaunchdService(g *libkb.GlobalContext, label string, serviceInfoPath
return errors.New("Unsupported on this platform")
}

// DebugSocketError allows platforms to help the user diagnose and resolve
// DiagnoseSocketError allows platforms to help the user diagnose and resolve
// socket errors.
func DiagnoseSocketError(ui libkb.UI, err error) {}
4 changes: 2 additions & 2 deletions go/client/markup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var spaceRE = regexp.MustCompile(`[[:space:]]+`)
// specify replaces arbitrary strings of whitespace with
// a single ' ' character. Also strips off leading and trailing
// whitespace.
func spacify(s string) string {
func specify(s string) string {
v := spaceRE.Split(s, -1)
if len(v) > 0 && v[0] == "" {
v = v[1:]
Expand All @@ -64,7 +64,7 @@ func spacify(s string) string {
// Output a paragraph to the io.Writer, applying the proper
// formatting.
func (p Paragraph) Output(out io.Writer) {
s := []byte(spacify(string(p.data)))
s := []byte(specify(string(p.data)))
if len(s) == 0 {
_, _ = out.Write(nl)
return
Expand Down