Remove libgconf-2-4 dependency #26149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gconf has not been required by electron since electron v3 libgconf-2-4 is unavailable in Debian trixie and Ubuntu mantic
|
This is such a minor change that greatly improves user adoption, can this move forward? |
|
bump |
|
Please bump it, because i can't use keybase on ubuntu 23.10. I don't want to install libgconf-2-4. |
|
+1 |
vorlock
added a commit
to vorlock/KBclient
that referenced
this pull request
Apr 9, 2024
libgconf-2-4 is not available in Debian since Aug 2023 and was required only for Gnome2, not a hard dependency as per GH#26149 (keybase#26149) libayatana-appindicator1 has been replaced with libayatana-appindicator3-1 some time ago also
vorlock
added a commit
to vorlock/KBclient
that referenced
this pull request
Apr 9, 2024
libgconf-2-4 is not available in Debian since Aug 2023 and was required only for Gnome2, not a hard dependency as per GH#26149 (keybase#26149) libayatana-appindicator1 has been replaced with libayatana-appindicator3-1 some time ago also
|
Yeah this is definitely a big issue now since the release of Ubuntu 24.04. Can we get this merged @pzduniak @joshblum @michalz-zoom please? |
|
The KeyBase Repo seems to be targeted by a Bot/Bad Actor :( |
Yes it's been a recent annoying issue with this repo. See #26657. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gconf has not been required by electron since electron v3: https://github.com/electron-userland/electron-installer-common/blob/1ef24cbba0db0fa392574595eaa00985a7587e7e/src/dependencies.js#L27-L32
The libgconf-2-4 package is unavailable in Debian trixie and Ubuntu mantic, resulting in installation errors on those platforms
I was able to force installation of keybase on Ubuntu 23.10 (mantic), despite the nonexistent dependency, keybase has been working fine for several weeks.
Fixes #26082, fixes #25984