Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to showing headers during sigs list #25931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default to showing headers during sigs list #25931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions go/client/cmd_sigs_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type CmdSigsList struct {
json bool
verbose bool
allKeys bool
headers bool
omitHeaders bool
types map[string]bool

username string
Expand Down Expand Up @@ -63,7 +63,7 @@ func (s *CmdSigsList) ParseArgv(ctx *cli.Context) error {
s.json = ctx.Bool("json")
s.verbose = ctx.Bool("verbose")
s.allKeys = ctx.Bool("all-keys")
s.headers = ctx.Bool("headers")
s.omitHeaders = ctx.Bool("omitHeaders")
s.filter = ctx.String("filter")

if err = s.ParseTypes(ctx); err != nil {
Expand All @@ -86,7 +86,7 @@ func (s *CmdSigsList) DisplayKTable(sigs []keybase1.Sig) (err error) {

var cols []string

if s.headers {
if !s.omitHeaders {
cols = []string{
"#",
"SigId",
Expand Down Expand Up @@ -211,8 +211,8 @@ func NewCmdSigsList(cl *libcmdline.CommandLine, g *libkb.GlobalContext) cli.Comm
Usage: "Show signatures from all (replaced) keys.",
},
cli.BoolFlag{
Name: "H, headers",
Usage: "Show column headers.",
Name: "H, omitHeaders",
Usage: "Omit column headers (e.g. for command-line processing).",
},
cli.StringFlag{
Name: "f, filter",
Expand Down