fix Dockerfile by copying executable to image #1600
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey it's a good idea, but you will need to adapt the cicd process also that depend on that, and make the file executable |
|
updated the PR, make the file executable for all users. @tchiotludo |
brian-mulier-p
force-pushed
the
develop
branch
from
8b19413
to
d28b63d
Compare
|
Next steps: refactor CI/CD to make it work with this executable |
tchiotludo
force-pushed
the
develop
branch
2 times, most recently
from
2dc2842
to
ab62ba9
Compare
tchiotludo
force-pushed
the
develop
branch
3 times, most recently
from
febd835
to
51d21c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Dockerfile doesn't copy executable to image, so the docker image newly built from this Dockerfile will not run.
close #1599