Enable serving framed kepler.gl-jupyter over https #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove HTTP protocol specifier to select the most appropriate protocol This is needed when kepler.gl is served on a website served via HTTPS. This is needed since chrome blocks loading of insecure resources when the page is served via HTTPS (Mixed content). Signed-off-by: Peder Voldnes Langdal <peder.github@langd.al>
heshan0131
reviewed
May 25, 2022
| @@ -100,11 +100,11 @@ function App() { | |||
| <title>Kepler.gl Jupyter</title> | |||
| <link | |||
| rel="stylesheet" | |||
| href="http://d1a3f4spazzrp4.cloudfront.net/kepler.gl/uber-fonts/4.0.0/superfine.css" | |||
| href="//d1a3f4spazzrp4.cloudfront.net/kepler.gl/uber-fonts/4.0.0/superfine.css" | |||
There was a problem hiding this comment.
Maybe just change this to https:// instead?
There was a problem hiding this comment.
What is holding up this PR? I have an https jupyterhub environment that would benefit from this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove HTTP protocol specifier for stylesheets used in
bindings/kepler.gl-jupyter/js/lib/keplergl/components/app.jsto select the most appropriate protocol.This is needed when kepler.gl is served on a website served via HTTPS. Today, this fails since chrome blocks loading of insecure resources when the page is served via HTTPS (Mixed content). However, Firefox and Safari are not as strict as chrome, so this fix is not needed for those browsers.
See image below to see what happened before this fix, included the error messages in the dev console at the bottom.