Bobby javavscript modernization #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
za419
reviewed
Feb 14, 2023
| postRequestID() | ||
| }) | ||
|
|
||
| let getVersion = () => { |
There was a problem hiding this comment.
Why is this a let? I don't think we should be reassigning these functions.
(etc for the others)
za419
reviewed
Feb 14, 2023
| // Loads and unloads audio stream source | ||
| document | ||
| .getElementById(PLAY_BUTTON) | ||
| .addEventListener('click', () => stream.paused ? play() : pause()) |
There was a problem hiding this comment.
Should we refactor this to be jQuery?
$(`#${PLAY_BUTTON}`).click(() => stream.paused ? play() : pause())There was a problem hiding this comment.
Also goes for other uses of document.getElementBy*
kenellorando
added
type: enhancement
stack: frontend
domain: cadence-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.