Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Programmer's Guide for documentation #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nulifier
Copy link

@Nulifier Nulifier commented Feb 6, 2018

I couldn't find any documentation on how to use this library. I noticed in #164 that there was a complaint that the documentation was not in a format that was editable so I went through the Programmer's Guide and changed it into markdown.

This won't exactly follow how openal-soft works but should form a good base for editing.

Let me know if it needs any changes.


#### alGetBooleanv
##### Description
This function returns an integer OpenAL state.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a copy-paste error, this should be boolean OpenAL state.

```cpp
void alGetBooleanv(
ALenum param,
ALboolean* data
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was intentional, but a number of functions seem to have extra indentation on some parameters.

| ----------------- | --------- | ----------- |
| AL_DOPPLER_FACTOR | `f` | Global Doppler factor |
| AL_SPEED_OF_SOUND | `f` | Speed of sound in units per second |
| AL_DISTANCE_MODEL | `f` | Distance model enumeration value |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL_DISTANCE_MODEL should have the i data type.

| AL_GAIN | `f`, `fv` | Master gain. Value should be positive |
| AL_POSITION | `fv`, `3f`, `iv`, `3i` | X, Y, Z position |
| AL_VELOCITY | `fv`, `3f`, `iv`, `3i` | Velocity vector |
| AL_ORIENTATION | `fv`, `fv` | Orientation expressed as "at" and "up" vectors |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be fv, iv.

```

Here is a graph showing the inverse distance curve:
![Inverse Distance Curve](images/figure-inverse-distance.jpg)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be showing as a link, rather than an inline image. The same happens for the Linear and Exponential figures, which also have an incorrect caption (they both say "Inverse Distance Curve" as well).

@BMarques
Copy link

Shouldn't this documentation also have OpenAL Soft specific details? Currently I'm implementing the audio subsystem with OpenAL Soft in my game, but I've no idea what are the specific OpenAL Soft changes, if there are any.

This documentation is also missing the Effects Extension Guide :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants