Extract dataset functionality for easy extensibility #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract dataset functionality for easy extensibility
Summary of changes:
dataset.py
withDataset
base class. It encapsulates downloading and iterating over examples in files. There are 3 methodsdownload()
,list_files()
,examples_of()
in the classtinystories.py
toDataset
train_vocab()
,pretokenize()
,process_shard()
tokenized_{vocab_size}
directories. Files tokenized by Llama2 tokenizer write totokenized_llama2
directory.dataset.py
To hold git diff as simple as possible, I have not renamed the main entry point file
tinystories.py
. But in future, it should be renamed to something likeprepare.py
.train.py
is not affected by this PR.