added config path to Service interface

linux_test/Makefile

@@ -3,7 +3,7 @@ all: sysv systemd upstart openrc clean
 
 # compile `go test` binary statically
 test:
-	@CGO_ENABLED=0 go test -installsuffix netgo -a -c ..
+	@CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go test -installsuffix netgo -a -c ..
 
 clean:
 	-rm service.test

service.go

@@ -387,6 +387,11 @@ type Service interface {
 	Status() (Status, error)
 }
 
+// ConfigInfoer is an optional interface which allows for certain information to be obtained.
+type ConfigInfoer interface {
+	ConfigPath() (string, error)
+}
+
 // ControlAction list valid string texts to use in Control.
 var ControlAction = [5]string{"start", "stop", "restart", "install", "uninstall"}
 

service_aix.go

@@ -26,6 +26,8 @@ const version = "aix-ssrc"
 
 type aixSystem struct{}
 
+var _ ConfigInfoer = &aixService{}
+
 func (aixSystem) String() string {
 	return version
 }
@@ -114,7 +116,7 @@ func (s *aixService) template() *template.Template {
 	}
 }
 
-func (s *aixService) configPath() (cp string, err error) {
+func (s *aixService) ConfigPath() (cp string, err error) {
 	cp = "/etc/rc.d/init.d/" + s.Config.Name
 	return
 }
@@ -131,7 +133,7 @@ func (s *aixService) Install() error {
 	}
 
 	// write start script
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -182,7 +184,7 @@ func (s *aixService) Uninstall() error {
 		return err
 	}
 
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -211,7 +213,7 @@ func (s *aixService) Status() (Status, error) {
 		}
 	}
 
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return StatusUnknown, err
 	}

service_darwin.go

@@ -70,6 +70,12 @@ type darwinLaunchdService struct {
 	userService bool
 }
 
+var _ ConfigInfoer = &darwinLaunchdService{}
+
+func (s *darwinLaunchdService) ConfigPath() (string, error) {
+	return s.getServiceFilePath()
+}
+
 func (s *darwinLaunchdService) String() string {
 	if len(s.DisplayName) > 0 {
 		return s.DisplayName

service_freebsd.go

@@ -57,6 +57,8 @@ type freebsdService struct {
 	*Config
 }
 
+var _ ConfigInfoer = &freebsdService{}
+
 func (s *freebsdService) String() string {
 	if len(s.DisplayName) > 0 {
 		return s.DisplayName
@@ -87,7 +89,7 @@ func (s *freebsdService) template() *template.Template {
 	}
 }
 
-func (s *freebsdService) configPath() (cp string, err error) {
+func (s *freebsdService) ConfigPath() (cp string, err error) {
 	cp = "/usr/local/etc/rc.d/" + s.Config.Name
 	return
 }
@@ -99,7 +101,7 @@ func (s *freebsdService) Install() error {
 	}
 
 	// write start script
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -135,15 +137,15 @@ func (s *freebsdService) Install() error {
 }
 
 func (s *freebsdService) Uninstall() error {
-	cp, err := s.configPath()
+	cp, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
 	return os.Remove(cp)
 }
 
 func (s *freebsdService) Status() (Status, error) {
-	cp, err := s.configPath()
+	cp, err := s.ConfigPath()
 	if err != nil {
 		return StatusUnknown, err
 	}

service_linux.go

@@ -21,6 +21,8 @@ type linuxSystemService struct {
 	new         func(i Interface, platform string, c *Config) (Service, error)
 }
 
+var _ ConfigInfoer = &linuxSystemService{}
+
 func (sc linuxSystemService) String() string {
 	return sc.name
 }
@@ -33,6 +35,9 @@ func (sc linuxSystemService) Interactive() bool {
 func (sc linuxSystemService) New(i Interface, c *Config) (Service, error) {
 	return sc.new(i, sc.String(), c)
 }
+func (sc linuxSystemService) ConfigPath() (string, error) {
+	return "", fmt.Errorf("not implemented")
+}
 
 func init() {
 	ChooseSystem(linuxSystemService{

service_openrc_linux.go

@@ -45,6 +45,8 @@ type openrc struct {
 	*Config
 }
 
+var _ ConfigInfoer = &openrc{}
+
 func (s *openrc) String() string {
 	if len(s.DisplayName) > 0 {
 		return s.DisplayName
@@ -77,7 +79,7 @@ func newOpenRCService(i Interface, platform string, c *Config) (Service, error)
 
 var errNoUserServiceOpenRC = errors.New("user services are not supported on OpenRC")
 
-func (s *openrc) configPath() (cp string, err error) {
+func (s *openrc) ConfigPath() (cp string, err error) {
 	if s.Option.bool(optionUserService, optionUserServiceDefault) {
 		err = errNoUserServiceOpenRC
 		return
@@ -87,7 +89,7 @@ func (s *openrc) configPath() (cp string, err error) {
 }
 
 func (s *openrc) Install() error {
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -129,7 +131,7 @@ func (s *openrc) Install() error {
 }
 
 func (s *openrc) Uninstall() error {
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}

service_solaris.go

@@ -68,6 +68,8 @@ type solarisService struct {
 	Prefix string
 }
 
+var _ ConfigInfoer = &solarisService{}
+
 func (s *solarisService) String() string {
 	if len(s.DisplayName) > 0 {
 		return s.DisplayName
@@ -98,7 +100,7 @@ func (s *solarisService) template() *template.Template {
 	}
 }
 
-func (s *solarisService) configPath() (string, error) {
+func (s *solarisService) ConfigPath() (string, error) {
 	return "/lib/svc/manifest/" + s.Prefix + "/" + s.Config.Name + ".xml", nil
 }
 
@@ -108,7 +110,7 @@ func (s *solarisService) getFMRI() string {
 
 func (s *solarisService) Install() error {
 	// write start script
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -161,7 +163,7 @@ func (s *solarisService) Install() error {
 func (s *solarisService) Uninstall() error {
 	s.Stop()
 
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}

service_systemd_linux.go

@@ -46,6 +46,8 @@ type systemd struct {
 	*Config
 }
 
+var _ ConfigInfoer = &systemd{}
+
 func newSystemdService(i Interface, platform string, c *Config) (Service, error) {
 	s := &systemd{
 		i:        i,
@@ -67,7 +69,7 @@ func (s *systemd) Platform() string {
 	return s.platform
 }
 
-func (s *systemd) configPath() (cp string, err error) {
+func (s *systemd) ConfigPath() (cp string, err error) {
 	if !s.isUserService() {
 		cp = "/etc/systemd/system/" + s.Config.Name + ".service"
 		return
@@ -134,7 +136,7 @@ func (s *systemd) isUserService() bool {
 }
 
 func (s *systemd) Install() error {
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -194,7 +196,7 @@ func (s *systemd) Uninstall() error {
 	if err != nil {
 		return err
 	}
-	cp, err := s.configPath()
+	cp, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}

service_sysv_linux.go

@@ -21,6 +21,8 @@ type sysv struct {
 	*Config
 }
 
+var _ ConfigInfoer = &sysv{}
+
 func newSystemVService(i Interface, platform string, c *Config) (Service, error) {
 	s := &sysv{
 		i:        i,
@@ -44,7 +46,7 @@ func (s *sysv) Platform() string {
 
 var errNoUserServiceSystemV = errors.New("User services are not supported on SystemV.")
 
-func (s *sysv) configPath() (cp string, err error) {
+func (s *sysv) ConfigPath() (cp string, err error) {
 	if s.Option.bool(optionUserService, optionUserServiceDefault) {
 		err = errNoUserServiceSystemV
 		return
@@ -64,7 +66,7 @@ func (s *sysv) template() *template.Template {
 }
 
 func (s *sysv) Install() error {
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -115,7 +117,7 @@ func (s *sysv) Install() error {
 }
 
 func (s *sysv) Uninstall() error {
-	cp, err := s.configPath()
+	cp, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}

service_test.go

@@ -41,6 +41,22 @@ func TestRunInterrupt(t *testing.T) {
 	}
 }
 
+func TestConfigPath(t *testing.T) {
+	p := &program{}
+	sc := &service.Config{
+		Name: "go_service_test",
+	}
+	s, err := service.New(p, sc)
+	if err != nil {
+		t.Fatalf("New err: %s", err)
+	}
+
+	_, err = s.(service.ConfigInfoer).ConfigPath()
+	if err != nil {
+		t.Fatal("Failed to fetch or not implemented")
+	}
+}
+
 const testInstallEnv = "TEST_USER_INSTALL"
 
 // Should always run, without asking for any permission

service_upstart_linux.go

@@ -35,6 +35,8 @@ type upstart struct {
 	*Config
 }
 
+var _ ConfigInfoer = &upstart{}
+
 func newUpstartService(i Interface, platform string, c *Config) (Service, error) {
 	s := &upstart{
 		i:        i,
@@ -61,7 +63,7 @@ func (s *upstart) Platform() string {
 // Upstart will be replaced by systemd in most cases anyway.
 var errNoUserServiceUpstart = errors.New("User services are not supported on Upstart.")
 
-func (s *upstart) configPath() (cp string, err error) {
+func (s *upstart) ConfigPath() (cp string, err error) {
 	if s.Option.bool(optionUserService, optionUserServiceDefault) {
 		err = errNoUserServiceUpstart
 		return
@@ -126,7 +128,7 @@ func (s *upstart) template() *template.Template {
 }
 
 func (s *upstart) Install() error {
-	confPath, err := s.configPath()
+	confPath, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}
@@ -164,7 +166,7 @@ func (s *upstart) Install() error {
 }
 
 func (s *upstart) Uninstall() error {
-	cp, err := s.configPath()
+	cp, err := s.ConfigPath()
 	if err != nil {
 		return err
 	}