Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve error handling for client auth #1069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: improve error handling for client auth #1069

wants to merge 2 commits into from

Conversation

MatteoVoges
Copy link
Contributor

Fixes issue in slack

Proposed Changes

  • improved error messages and cases
  • enabled verifying with ca-bundle by default
  • disabled ssl warnings when VAULT_SKIP_VERIFY is set to true

Docs and Tests

  • Tests updated
  • Updated documentation --> unnecessary

@MatteoVoges MatteoVoges added the enhancement enhancement to an existing feature label Oct 5, 2023
@MatteoVoges MatteoVoges self-assigned this Oct 5, 2023
@github-actions github-actions bot added the Stale label Dec 5, 2023
@github-actions github-actions bot removed the Stale label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaro ramaro Awaiting requested review from ramaro

@ademariag ademariag Awaiting requested review from ademariag

At least 1 approving review is required to merge this pull request.

Assignees

@MatteoVoges MatteoVoges

Labels
enhancement enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MatteoVoges