Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit changes #1058

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Pre-commit changes #1058

wants to merge 2 commits into from

Conversation

ademariag
Copy link
Contributor

Fixes issue #

Proposed Changes

  • fix lint and other pre-commit changes

MatteoVoges
MatteoVoges approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@MatteoVoges MatteoVoges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding isort-checking in the lint job?

@MatteoVoges
Copy link
Contributor

What about adding isort-checking in the lint job?

This would just require adding this action to it:
- uses: isort/isort-action@master

@ademariag ademariag marked this pull request as ready for review October 1, 2023 21:46
@ademariag ademariag marked this pull request as draft October 1, 2023 22:21
@github-actions github-actions bot added the Stale label Dec 1, 2023
@github-actions github-actions bot removed the Stale label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoVoges MatteoVoges Awaiting requested review from MatteoVoges

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ademariag @MatteoVoges