Add default opengraph on error (#5552)

kamranahmedse · Apr 25, 2024 · 3a1b896 · 3a1b896
1 parent caa8681
commit 3a1b896
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/src/lib/open-graph.ts b/src/lib/open-graph.ts
@@ -6,3 +6,8 @@ type RoadmapOpenGraphQuery = {
 export function getOpenGraphImageUrl(params: RoadmapOpenGraphQuery) {
   return `${import.meta.env.DEV ? 'http://localhost:3000' : 'https://roadmap.sh'}/og-images/${params.group}/${params.resourceId}.png`;
 }
+
+export async function getDefaultOpenGraphImageBuffer() {
+  const defaultImageUrl = `${import.meta.env.DEV ? 'http://localhost:3000' : 'https://roadmap.sh'}/images/og-img.png`;
+  return fetch(defaultImageUrl).then((response) => response.arrayBuffer());
+}
diff --git a/src/pages/og/[slug].ts b/src/pages/og/[slug].ts
@@ -1,4 +1,5 @@
 import type { APIRoute } from 'astro';
+import { getDefaultOpenGraphImageBuffer } from '../../lib/open-graph';
 
 export const prerender = false;
 
@@ -10,26 +11,22 @@ export const GET: APIRoute<any, Params> = async (context) => {
   const { slug } = context.params;
 
   if (!slug.startsWith('user-')) {
-    return new Response(
-      JSON.stringify({
-        error: 'Invalid slug',
-      }),
-      {
-        status: 400,
+    const buffer = await getDefaultOpenGraphImageBuffer();
+    return new Response(buffer, {
+      headers: {
+        'Content-Type': 'image/png',
       },
-    );
+    });
   }
 
   const username = slug.replace('user-', '');
   if (!username) {
-    return new Response(
-      JSON.stringify({
-        error: 'Invalid username',
-      }),
-      {
-        status: 400,
+    const buffer = await getDefaultOpenGraphImageBuffer();
+    return new Response(buffer, {
+      headers: {
+        'Content-Type': 'image/png',
       },
-    );
+    });
   }
 
   const response = await fetch(