csi: Allow over-provisioning for external volume #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: handrea2009 <handrea2009@gmail.com>
handrea2009
changed the title
|
From #1036 (comment), @handrea2009 could you pls make the change as not to overprovision as that would be a bug fix? My reasoning is, if we provide overprovisioning as a feature we should also surface either how much overprovision should be supported via user input or how much we overprovisioned as of now, however none of these are possible and taking in this PR would be extending the buggy nature. minor: pls do sign your commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It allow over-provisioning for external volume
Which issue(s) this PR fixes:
Fixes #1036 (https://github.com/handrea2009/issue-1036)
Special notes for your reviewer:
If we don't want to allow over-provisioning then we have to to add only the update_free_size() in CreateVolume() when ext_volume before returning, cause currently the free size is not updated in this case