[WIP] added more information in 'k0s install; command #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
jasmingacic
force-pushed
the
install_info
branch
from
cf7c73d
to
f38b1a1
Compare
jasmingacic
commented
Dec 17, 2020
| @@ -65,7 +65,10 @@ func EnsureService(args []string) error { | |||
| svcConfig.Dependencies = deps | |||
| svcConfig.Arguments = args | |||
|
|
|||
| logrus.Info("Installing k0s service") | |||
| fmt.Println("Installing k0s service") | |||
| fmt.Println("Service information:", s.Platform()) | |||
There was a problem hiding this comment.
I intentionally put fmt to print out these values since I was not able to remove time stamps from logrus.Infof
|
I will close this for now since the upstream PR (kardianos/service#255) hasn't been merged yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a placeholder for cmd install improvement.
this is depending on kardianos/service#255 getting merged
The PR is required so I can easily integrate k0s into LP. The vital piece of information is ability to edit k0s.service for worker so the join token can be injected.