New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obvious Fix: RSA flaky test #74

Open

alesbolka wants to merge 1 commit into jwtk:master from alesbolka:rsa-test-fix

alesbolka commented Aug 7, 2020

Signing algorithm was not set correctly
Result of token validation was not checked

Test failed even though the validation was not done properly


          Flaky test fix

28edd7c

- Signing algorithm was not set correctly
- Result of token validation was not checked

Contributor

swiftone commented Aug 12, 2020

@alesbolka - Thanks for the PR!

Okta now maintains this repo, so the contribution rules have updated a bit.

While your changes are fairly small, it would make things easier if you either:

Signed a CLA and emailed it as described here: https://developer.okta.com/cla/
OR
Change the PR title to include "Obvious Fix", showing your agreement to that interpretation

Then we'll forward with this.

Thanks again for the PR, and thanks for dealing with this one-time legal hassle.

alesbolka changed the title ~~RSA flaky test~~ Obvious Fix: RSA flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment