Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup codebase and fix formatting #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

typerandom
Copy link
Contributor

@typerandom typerandom commented Oct 3, 2016

Important

This branch was based off of #29. Because that contained quite a bit of refactoring already. So that one needs to be reviewed/merged before this one is.

What this include

  • Formatting validation using ESLint. Same that we have in our other Node.js projects.
  • Seperation of prototypes and helper functions in index.js into separate logical files.

How to verify

Look through the changes in the codebase and run the tests. Run $ npm run lint to assert that the formatting passes the lint requirements.

Fixes #21

@coveralls
Copy link

coveralls commented Oct 3, 2016

Coverage Status

Coverage decreased (-68.2%) to 31.839% when pulling 1563ec2 on fix-formatting into 9e177c3 on master.

@typerandom
Copy link
Contributor Author

For some reason coverage has dropped. This refactor should not have affected coverage in any major way. So it's probably because of the new file separation that is causing some tests to not report correctly. I'm going to look into this.

@coveralls
Copy link

coveralls commented Oct 5, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 1c76f84 on fix-formatting into 9e177c3 on master.

@coveralls
Copy link

coveralls commented Oct 7, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling d46d1f9 on fix-formatting into 9e177c3 on master.

@typerandom typerandom mentioned this pull request Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants