-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudioThrottler & CircularBuffer #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallet
changed the title
Audio: Throttler & CircularBuffer. Recorder got reworked.
Audio: Throttler & CircularBuffer
May 4, 2022
jwallet
changed the title
Audio: Throttler & CircularBuffer
AudioThrottler & CircularBuffer
May 4, 2022
we need at least 1s of offsetbuffer to match waveFormat.averageBitratePerSec
Closed
jwallet
added a commit
that referenced
this pull request
Jun 22, 2022
AudioThrottler & CircularBuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ideal either, it has difficulty to know when to cut when the user skip a track since Spotify immediately plays the other. So I will have to add a toggle feature on it. The feature can be useful if the user records a playlist and do not touch Spotify until the recording is done.
The user will probably have to turn off
Automix
andCrossfade
features in Spotify Playback settingsmay help resolve issue #359
tweaked resolve #411
relates to #399 #247 #83 #100
may help resolve issue #170 (if spotify does not provide the track info, it won't do much)
AudioCircularBuffer keeps track of the current playback for about 10 seconds then overwrite itself
AudioThrottler sets the Buffer 5 seconds behind, it has 3 types of reader.
Once Spotify changes to the next track,
TrimStart
will be fired for the new recording,TrimEnd
will be fired for the old recording, otherwiseNone
will always be the default value.