WIP: Switched to real Resque and fakeredis. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It didn't make sense to copy / rewrite *all* of Resque, just to add some assertions to it. Instead, I'm using fakeredis and actual Resque. That way, all the persistence happens in-memory (so you don't need to run Redis yourself), and I can take advantage of the built-in methods Resque has for looking through queues and running jobs. This should be way more reliable and easy to maintain. Currently, the regular assertions pass. I'm still working on the scheduler assertions.
justinweiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't make sense to copy / rewrite all of Resque, just to add some
assertions to it. Instead, I'm using fakeredis and actual Resque. That
way, all the persistence happens in-memory (so you don't need to run
Redis yourself), and I can take advantage of the built-in methods Resque
has for looking through queues and running jobs. This should be way more
reliable and easy to maintain.
Todo: