Allow us to disable the default keymappings easily

[aileot]

Before the PR, the default keymappings sometimes annoyed us, who would like to use s as vim's default (the synonym for cl) and so on.

[justinmk]

This makes no sense. And plugins that have this kind of option are broken.

Sneak will not map s if the user has mapped <Plug>Sneak_s/S to anything else:

nmap ? <Plug>Sneak_s
nmap ? <Plug>Sneak_S

If that's too much work, then why have Sneak installed in the first place? Its entire purpose is to provide a mapping. If you don't like the default mapping then you need to choose a different mapping (as shown above). So a "disable mappings" option makes no sense.

[justinmk]

Added documentation :help sneak-disable-mappings in 0841477

[aileot]

You seems to have overlooked some users

1. who want to map only with sneak#wrap() flexibly, but without <Plug>Sneak_foo
2. who want to use Sneak only buffer-locally, like readonly-buffer or in specific filetype/buftype
3. who only want to use <Plug>Sneak_f/t or <Plug>SneakLabel_s and so on, but without <Plug>Sneak_s

I may also overlook other problems which the feature solve.

Isn't it an easiest, certain way for Sneak users to understand in the analogy of other vim-plugins which have g:foo#no_default_mappings? Or do you have any other reasons to cling to the current, smartest way?

[justinmk]

Thanks, that is a good list of use cases. In those cases user is going to a lot of trouble already, so this is not much more trouble:

map <f99> <Plug>Sneak_s<Plug>Sneak_S
map! <f99> <Plug>Sneak_s<Plug>Sneak_S

However it's definitely obscure. Sneak has a bunch of weird options already so I guess I will cave here.

[justinmk]

flip it so it is "positive logic"

Suggested change

	g:sneak#no_default_mappings = 0
	g:sneak#default_mappings = 1

[aileot]

I prefer the negative one here because it sounds natural for me (at least) to be set to 0 as default, and user will set it to 1 to turn on especially when an option expects either 0 or 1 as "OFF" or "ON".

Addition to that, I usually unify default values to be set to 0 unless the variable has specific reason to be other than 0; such unification reduces unnecessary chances that users should grep default values.

However, I also know positive logic is preferable in most cases so that it's a matter of taste after all. Please adopt the one on your preference.