Enforce search behavior according to &foldopen #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| \ ,'streak' : get(g:, 'sneak#streak', 0) && (v:version >= 703) && has("conceal") | ||
| \ ,'streak_esc' : get(g:, 'sneak#streak_esc', "\<space>") | ||
| \ ,'prompt' : get(g:, 'sneak#prompt', '>') | ||
| \ } |
There was a problem hiding this comment.
That just happened accidentally. I have a leader command to indent the whole file, and apparently some of my indentation settings are a little different from yours.
|
Thanks, I will test this later. Functional tests would help too, though it's fine if you don't want to. |
milsen
added a commit
to milsen/vim-sneak
that referenced
this pull request
Aug 4, 2015
See issue justinmk#102 and pull request justinmk#152.
milsen
added a commit
to milsen/vim-sneak
that referenced
this pull request
Aug 4, 2015
For "set foldlevel-=search" sneaking did not properly skip to the end of closed folds. Now it does. See pull request justinmk#152.
milsen
added a commit
to milsen/vim-sneak
that referenced
this pull request
Aug 4, 2015
Give the do-blocks a better description and remove unnecessary option settings in the execute-blocks. See justinmk#152.
Sneaking now behaves like / when "foldopen-=search" is set: Closed folds are considered to be single targets and are not opened when sneaking to them. They are opened, however, when the default-&foldopen is used or "foldopen+=search" is set. Resolve justinmk#102. This does not affect streak-mode (which still ignores &foldopen).
See issue justinmk#102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #102. Sneaking with
set foldopen-=searchwill now handle closed folds like single targets and skip over multiple search results inside of them. Withset foldopen+=search, i.e. the default behavior, closed folds are opened when sneaking to them.Streak-mode behavior is not influenced by this patch.