Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerspawner.py support mount type args #509

Closed
wants to merge 1 commit into from

Conversation

zhangnew
Copy link

class Mount(target, source, type='volume', read_only=False, consistency=None, propagation=None, no_copy=False, labels=None, driver_config=None, tmpfs_size=None, tmpfs_mode=None)

see https://docker-py.readthedocs.io/en/stable/api.html#docker.types.Mount

Copy link

welcome bot commented Nov 20, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@manics
Copy link
Member

manics commented Nov 20, 2023

Can you explain why this is needed? args = dict(mount) already incorporates those arguments if they've passed, and if they're not then the Docker defaults are used.

@zhangnew zhangnew closed this Nov 20, 2023
@zhangnew zhangnew deleted the patch-1 branch November 20, 2023 15:11
@zhangnew
Copy link
Author

Sorry, it's my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants