Refresh test workflow and associated config, accept podmain test failure for now #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/fix-tests
branch
from
234e836
to
1184754
Compare
|
Last attempt at the podman tests was #470 |
d.services.list throws TypeError instead of APIError with podman
consideRatio
force-pushed
the
pr/fix-tests
branch
from
411eeb8
to
90a99f4
Compare
|
It seems it comes down to this:
This in turn comes down to this: |
consideRatio
force-pushed
the
pr/fix-tests
branch
2 times, most recently
from
dcfbce3
to
ed12313
Compare
consideRatio
changed the title
consideRatio
commented
May 31, 2023
consideRatio
force-pushed
the
pr/fix-tests
branch
from
ed12313
to
7296a2d
Compare
minrk
approved these changes
May 31, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the very old test workflow and associated configuration, allowing all tests besides one tracked by #484 to pass successfully. Pinning sqlalchemy to version 1 was a key thing done but there was several smaller things that needed to be done. I've made a few comments about those changes below.