Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Limit test cell height extension #1656

Closed

Conversation

Alireza-Iranpour
Copy link

See the thread for PR #1650. This PR was split from that one. This PR is just for the limit test cell height extension.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch UBC-DSCI/nbgrader/limit_test_cell_hight_extension

@trevorcampbell
Copy link
Contributor

nbextensions is gone now as of 0.9.x . So this one will need to be revised. But I think JLab comes with a configurable max cell height property / scrollable cells now, doesn't it? So perhaps we don't even need this feature any more.

@brichet
Copy link
Contributor

brichet commented Feb 22, 2024

@Alireza-Iranpour @trevorcampbell should we close this PR ?

@trevorcampbell
Copy link
Contributor

@brichet Yes -- I think we would need to re-do it from scratch anyway now with the new JLab

@brichet
Copy link
Contributor

brichet commented May 16, 2024

@trevorcampbell thanks for answering, let's close it, then.
Feel free to reopen it if required.

@brichet brichet closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants