Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations of ioutil #3370

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

barthr
Copy link
Contributor

@barthr barthr commented Jul 14, 2023

This PR addresses the recent deprecations in Go 1.16. I replaced them to the suggested versions (some of these methods where already under the hood calling the correct methods).

@junegunn
Copy link
Owner

Thanks, I wasn't aware of the deprecation. Did you use some kind of a linter or did you manually look for ioutil references?

@junegunn junegunn merged commit 3c09c77 into junegunn:master Jul 16, 2023
5 checks passed
@barthr
Copy link
Contributor Author

barthr commented Jul 16, 2023

I did look for manual ioutil references. However, the trigger came from a static analyzer (the one included in intelij, so not aware which command line tool provides this functionality).

To add to that, I think using something like https://github.com/golangci/golangci-lint can be quite beneficial to the project, since it runs quite some linters. This can also be added as ci step to run on every PR. If this is something you are interest in, I can make a proof of concept PR.

@barthr barthr deleted the fix-deprecated-ioutil-calls branch July 16, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants