Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor util.go #3065

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor util.go #3065

wants to merge 1 commit into from

Conversation

zeek0x
Copy link
Contributor

@zeek0x zeek0x commented Nov 29, 2022

  • add Min16, Constrain16, AsUint32
  • unify Min*, Max* inequalities to > or < excluding >= or <=
  • omit types of function arguments

@junegunn
Copy link
Owner

junegunn commented Dec 2, 2022

  • sort functions

I'd rather not do this, it makes it hard to see the diff or track the changes (git blame) in a line range.

You see it's hard to see if the moved functions are the same as before or not: https://github.com/junegunn/fzf/pull/3065/files

- add Min16, Constrain16, AsUint32
- unify Min*, Max* inequalities  to `>` or `<` excluding `>=` or `<=`
- omit types of function arguments
@zeek0x zeek0x force-pushed the refactor/util branch 2 times, most recently from 144e7b5 to 37693ca Compare December 5, 2022 12:40
@junegunn
Copy link
Owner

omit types of function arguments

I'm just being curious. Is this the recommended style these days? Are you following a specific Go style guide? The code we're discussing here dates back to early 2015. I don't recall following any style guides back then. I wonder if the community standard has evolved over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants