Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make usage(--help) neater. #2796

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make usage(--help) neater. #2796

wants to merge 2 commits into from

Conversation

Pandademic
Copy link

also:

  • clean up atoi error msg.

@Pandademic
make usage(--help) neater.
b93c313 
also:
* clean up atoi error msg.
Jiehong
Jiehong reviewed Jun 4, 2022
View reviewed changes
src/options.go Show resolved Hide resolved
electron271
electron271 approved these changes Jul 4, 2022
View reviewed changes
Copy link

@electron271 electron271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not sure how much having any instance of not be uppercase will help, seems a bit more aggressive.

@Pandademic
Copy link
Author

@electron271 , I feel it makes it more easy to see the "not" right away , as it stands out more.

Thanks for your review!

@electron271
Copy link

I personally would only put it on options where if you miss the not, it might screw something up

@Pandademic
Copy link
Author

@electron271 , sorry for the late reply.Can you suggest any such options?

@electron271
Copy link

I dunno, haven't used fzf in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiehong Jiehong Jiehong left review comments

@electron271 electron271 electron271 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pandademic @electron271 @Jiehong