WIP. Refactor GRBupdatemodel calls #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torressa
changed the title
|
CI will fail because you don't have access to the CI secrets. I'll send you an invite, and then you can push to the |
|
I remember when writing parts of this that I got very confused as to when a call to GRBupdate was necessary. So I defaulted to requiring an update anytime the model was modified, and ensuring update had been called before querying any data about the model. |
|
Thanks Oscar! I've managed to get the CI to run. I'll continue in the other PR. Sorry for the mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
The idea is to only call
GRBupdatemodelbeforeGRBget*.Some tests are failing still:
test_Buffered_deletion_test,test_modify_after_delete*(indexing should also be updated with delete? This is not expected from our other APIs)Fixes #516