Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - add parsing/scoping capabilities for edits to single tokens #488

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Jan 25, 2020

An attempt to limit the amount of work done for static analysis. This identifies edits that can be made by altering terminal expr (i.e. those without child expr, such as identifiers and literals) that don't require us to run a full scopepass.

The (computational) savings should be significant, i.e. it should mean we're doing no unnecessary work when writing numbers, white space, editing identifiers or strings.

At the moment its delicate, it'll need a bit more work to ensure its robust enough.

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@262ab2a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #488   +/-   ##
=========================================
  Coverage          ?   35.07%           
=========================================
  Files             ?       21           
  Lines             ?     1628           
  Branches          ?        0           
=========================================
  Hits              ?      571           
  Misses            ?     1057           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262ab2a...a81b137. Read the comment docs.

@davidanthoff davidanthoff added this to the Current milestone Jan 26, 2020
@davidanthoff davidanthoff added this to In progress in Current via automation Jan 26, 2020
@davidanthoff davidanthoff removed this from In progress in Current Jan 26, 2020
@davidanthoff davidanthoff modified the milestones: Current, Backlog Jan 26, 2020
@davidanthoff
Copy link
Member

I've put this on the backlog, or did you want to ship this with the next release?

@ZacLN
Copy link
Contributor Author

ZacLN commented Jan 27, 2020

Lets wait on this one

@ZacLN ZacLN mentioned this pull request Jun 1, 2020
4 tasks
@davidanthoff davidanthoff removed this from the Backlog milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants