-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - add parsing/scoping capabilities for edits to single tokens #488
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
=========================================
Coverage ? 35.07%
=========================================
Files ? 21
Lines ? 1628
Branches ? 0
=========================================
Hits ? 571
Misses ? 1057
Partials ? 0 Continue to review full report at Codecov.
|
I've put this on the backlog, or did you want to ship this with the next release? |
Lets wait on this one |
An attempt to limit the amount of work done for static analysis. This identifies edits that can be made by altering terminal expr (i.e. those without child expr, such as identifiers and literals) that don't require us to run a full scopepass.
The (computational) savings should be significant, i.e. it should mean we're doing no unnecessary work when writing numbers, white space, editing identifiers or strings.
At the moment its delicate, it'll need a bit more work to ensure its robust enough.