Config loggers by labels #50
Open
+356
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support labels from Juju, we would like to be able to configure loggers by their labels. So if a logger has a label of a model namespace (UUID) then searching from the root module to set the level of a module should be possible. As you can configure both module names and labels at the same time, this becomes tricky. We don't want users to be able to configure a logger via a label directly and the label should always take precedence over a user input.
Labels should not be applied to loggers. There is no way to reference them directly from a root module. Labels for this concept should be more like Attributes, something that can be dynamic for a given logger, although I suspect that they should just be sent via the Logf method.
It's much cleaner if we can reuse existing methods to provide the additional functionality. The labels provide addition matching capabilities to config loggers and will only config the loggers that have a label intersection.
Take into consideration the labels when resetting the logger levels. We don't want to reset all the logger levels if we're using a singular global logger.
SimonRichardson
force-pushed
the
config-loggers-by-labels
branch
from
dd71032
to
861be55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support labels from Juju, we would like to be able to
configure loggers by their labels. So if a logger has a label of a
model namespace (UUID) then searching from the root module to set the
level of a module should be possible.
Label matching can be applied to the loggers by providing a set of labels
to the ConfigureLoggers method. If a logger has a label that matches the
provided labels, then the logger will be configured with the provided level.
If the logger does not have a label that matches the provided labels, then
the logger will not be configured. No labels will configure all loggers in the
specification.
In addition, I've removed the attachment of the dynamic labels to the logger
type. There isn't a usage from Juju's perspective to ever need them. Loggo
is a hierarchical model, where loggers inherit from their parents. The original
label concept didn't follow that concept. For example, module names walk
their parents for an effective level if a level hasn't been set. We do the inverse
for labels, where the parent sets the child labels on construction (labels are
immutable atm), but they do follow the same concept; child-parent relationship.