Fix architecture detection on ppc64le #1344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juce_runtime_arch_detection.cpp currently identifies ppc64le as ppc64, which causes it to use the directory name `ppc64-linux` for VST 3 plugin contents. However, VST 3 specifies that `uname -m` should be used as the first component of the directory name, which on 64-bit little-endian PowerPC is `ppc64le`. Currently, this causes problems building VST 3 plugins on this platform, as the VST 3 SDK expects the module directory to be named `ppc64le-linux`. This commit adds an additional endianness check when 64-bit PowerPC is detected, outputting `ppc64` or `ppc64le` as appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
juce_runtime_arch_detection.cpp currently identifies
ppc64leasppc64, which causes JUCE to use the directory nameppc64-linuxfor VST 3 plugin contents. However, VST 3 specifies thatuname -mshould be used as the first component of the directory name, which on 64-bit little-endian PowerPC isppc64le.Currently, this causes problems when building VST 3 plugins on this platform, as the VST 3 SDK expects the module directory to be named
ppc64le-linux.This PR adds an additional endianness check when 64-bit PowerPC is detected, outputting
ppc64orppc64leas appropriate.