Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the web ui more to chrome's liking #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moneromooo-monero
Copy link
Contributor

chrome does not like setting innerHTML, because it might be vulnerable
to injection, but since we don't add user controlled data, we're fine

require-trusted-types-for 'script'; trusted-types default; needs adding
to Content-Security-Policty, see:

https://stackoverflow.com/questions/62810553

@jtgrassie
Copy link
Owner

Interesting. Pretty sure this will need to be a child of <head> (not <html>), to pass validation though.

chrome does not like setting innerHTML, because it might be vulnerable
to injection, but since we don't add user controlled data, we're fine

require-trusted-types-for 'script'; trusted-types default; needs adding
to Content-Security-Policty, see:

https://stackoverflow.com/questions/62810553
@moneromooo-monero
Copy link
Contributor Author

Confirmed to work after the move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants