Added an ImapToken cache to try and reduce ImapToken allocations #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How much, in terms of allocations, does the ImapTokenCache save us? No cache (for comparison): With this PR (cache capacity = 128): capacity = 256: |
jstedfast
force-pushed
the
imap-token-cache
branch
from
a50f9a2
to
7632855
Compare
jstedfast
force-pushed
the
imap-token-cache
branch
from
ba9a703
to
3b06559
Compare
jstedfast
force-pushed
the
imap-token-cache
branch
from
8f8673d
to
ac4e4f1
Compare
Also reduced memory allocations in ImapTokenCache.AddOrGet()
…lders This drastically reduces the number of allocations made when tokenizing IMAP responses. ImapCommand's usage was not really a major issue, but since ImapEngine.ReadLine/Async() needed a reusable ByteArrayBuilder anyway, might as well share that with ImapCommand.
…own too large One potential problem with reusing ByteArrayBuilders is that, because they can grow for some abnormally long tokens/lines/commands/etc, those oversized buffers will remain referenced by the ImapStream/ImapEngine until they are disposed which could be the life of the program. If we oportunistically scale back the size of the buffers when they are Clear()'d, then we can periodically reduce memory usage and allow those larger buffers to be used elsewhere.
jstedfast
force-pushed
the
imap-token-cache
branch
from
ac4e4f1
to
d82f45c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically, this could drastically reduce ImapToken allocations which might help with issue #1335.
Of course, this also adds more overhead in other aspects.
TODO: