Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux/windows keybindings #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sylvaindumont
Copy link

@sylvaindumont sylvaindumont commented Jan 10, 2018

Add alt-shift-t keybinding to open terminal.
It allows non mac user to open terminal with keybinding.

It could help with #6 if we remove cmd-shift-t.

@daviwil
Copy link
Collaborator

daviwil commented Jan 10, 2018

+1 for platform-agnostic keybindings

@jsmecham jsmecham added this to the 0.4.0 milestone Jan 10, 2018
@jsmecham
Copy link
Owner

Agree that cmd-shift-t is probably not a good default, although that is what I would choose to map personally. We shouldn't clobber existing conventions out of the box, though.

@daviwil
Copy link
Collaborator

daviwil commented Jan 17, 2018

I noticed that they keybinding-resolver package uses these CSS classes to do platform-specific bindings:

{
  ".platform-darwin": {
    "cmd-.": "key-binding-resolver:toggle"
  },
  ".platform-win32": {
    "ctrl-.": "key-binding-resolver:toggle"
  },
  ".platform-linux": {
    "ctrl-.": "key-binding-resolver:toggle"
  }
}

I wonder if we could do something similar?

@jsmecham jsmecham removed this from the 0.5.0 milestone Feb 11, 2018
@sylvaindumont
Copy link
Author

as proposed by @daviwil I added platform specific bindings, it doesn't change anything for mac users, cmd-shift-t still open terminal instead of reopening last closed tab.

alt-shift-t open terminal for windows/linux users to avoid introducing #6 on windows/linux

I hope to be able to restore this, but right now it conflicts with a whole slew of keybindings in Atom on the Mac.
@jsmecham
Copy link
Owner

I'm going to address this in #66. Would you mind rebasing this PR on that branch? I'll merge it there and probably make a bunch of changes for Windows and Mac, as well.

"alt-shift-t": "terminal:open"
},
".platform-win32 terminal-view": {
"ctrl-c": "terminal:copy",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to bind to Ctrl-C on Windows, as that's a standard shortcut for interrupting a program when running in a terminal.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On linux too. I wanted to stay close of mac keybinding until we find better ideas, will replace by #62 proposition ctrl shift c/v/k
cmd shift k on mac could solve what you fix with 713fe60

@sylvaindumont
Copy link
Author

@jsmecham rebased on #66 and copy/paste conflicts fixed

@forresthopkinsa
Copy link

What's the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants