added credential id key for certificates #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to have an optional credential id right side of the certificate name. I added this right after `#cert.name` ```typ #h(1fr)ID: #cert.id ```
|
Hi! Thank you for the pull request. Let me get back to you once I review it. |
jskherman
reviewed
Apr 7, 2024
jskherman
reviewed
Apr 7, 2024
There was a problem hiding this comment.
Would it also be possible for you to add the accompanying JSON schema for the ID field in the cv.typ.schema.json file?
Co-authored-by: Je Sian Keith Herman <68434444+jskherman@users.noreply.github.com>
|
Alright, I'll add it in a bit |
didn't realize that the previous code was wrong
|
@jskherman ah, this should work now... i just noticed that the previous commits were wrong. This should work now? It does work for this kind of input though: certificates:
- name: "Banana"
date: 2022-07-01
issuer: Another Issuer
url:
id: ID-HERE-1412
- name: "Microsoft maybe"
date: 2021-04-11
issuer: Github
url:
id:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to have an optional credential id right side of the certificate name.
I added this right after
#cert.nameI would have used the word "Credential ID" but some ids are 40 characters long thus I used "ID" instead.