Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow omitting of dates from date ranges #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aparaxium
Copy link
Contributor

Allows the user to omit dates in date ranges using the logic:

#let daterange(start, end) = {
    if start != none and end != none [
        #start #sym.dash.en #end
    ]
    if start == none and end != none [
        #end
    ]
    if start != none and end == none [
        #start #sym.dash.en Present
    ]
}

@Aparaxium Aparaxium mentioned this pull request Jan 7, 2024
@jskherman
Copy link
Owner

Hi @Aparaxium, can you give some example cases where omitting dates (both dates and just one of the dates) in places that have date ranges would be valuable? So far, a valid case has been brought to attention in issue #10 where someone would need to hide their length of stay in an educational institution.

For the use case of having the end date of "present", it can just be included in the YAML file as a value as mentioned in issue #4.

@Aparaxium
Copy link
Contributor Author

Aparaxium commented Jan 11, 2024

Hello,

Initially I had intended to remove the dates from the projects fields because I found it difficult to remember when I started on many of them. I then extrapolated this to every date range field.

I understand if this is something you don't want to include or want the implementation details to be changed, however i took care to try to make sure it would handle every case and it remains optional for the user.

Here are some other reasons to exclude dates:

  • Employers can guess at the age of an employee
  • Gaps in employment can disqualify good candidates from getting their foot in the door, which can apply to people transitioning careers

@Aparaxium
Copy link
Contributor Author

Hello,

I just realized that the json schema needs to be updated to facilitate this.

@jskherman
Copy link
Owner

I see, thanks for expanding. The context for me is a lot clearer now.

On a side note, over the implementation, I've looked over the utils.daterange() and all seems good to merge (now to just solve the merge conflict...). Thank you for also updating the JSON schema.

Let me know if it is all good for merging :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants