Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to two functions which, since their detection failure returns false, have their return values annotated as
{boolean|string}
. In reality, the boolean returned is alwaysfalse
, and so it makes more sense to use a JSDoc type expression offalse
.With the return type as boolean i.e.
{true|false}
a usage with a short circuit assignment to a
{string}
var will cause a false positive type warning:as the language server infers from the
{boolean|string}
type annotation(s) thatlookup
will in some scenarios return true, which would makecontentType
no longer a{string}
.