Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer environment and better coding practices #326

Merged
merged 14 commits into from
May 27, 2024

Conversation

jseidl
Copy link
Owner

@jseidl jseidl commented Apr 14, 2024

This PR introduces the merge of integration_blueprint into this repo. A few things such as vscode devcontainer environment and configuration for black, flake8, pylint and isort.

A few workflows changed a few more to come whenever I'm able to start on tests.

I've ran the "autofixes' from ruff, black and isort but I still need to work on general docstring and code enhancements before it can pass ruff check which is the goal.

My stretch goal is to add typing with mypy

@jseidl jseidl self-assigned this Apr 15, 2024
@jseidl jseidl marked this pull request as draft April 15, 2024 09:20
@jseidl jseidl added the enhancement Enhancement of existing feature label Apr 15, 2024
@jseidl
Copy link
Owner Author

jseidl commented Apr 24, 2024

After a lot of work to get the linters happy and tests to start rolling off, I broke some stuff but it's now (apparently) fixed.

I made a test to test that the area goes to on when a presence sensor is detected. I need to modify the test area config to have a short clear timeout so I can add the negative test.

@jseidl jseidl marked this pull request as ready for review May 27, 2024 06:37
@jseidl
Copy link
Owner Author

jseidl commented May 27, 2024

Closes #331 and #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant