Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for underscore participants #1953

Merged
merged 7 commits into from
May 12, 2024
Merged

Conversation

Narigo
Copy link
Member

@Narigo Narigo commented Apr 28, 2024

We had two participants with underscores in front of the JSON filename. It looks like they were not actually counted as registrations.

This PR fixes the test to reflect what the test description says and renames the two participants JSON files (@HeeL and @Pipo93).

Signed-off-by: Joern Bernhardt <joern.bernhardt@googlemail.com>
Signed-off-by: Joern Bernhardt <joern.bernhardt@googlemail.com>
…underscore

Signed-off-by: Joern Bernhardt <joern.bernhardt@googlemail.com>
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit 5a1921c
🔍 Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/662ea11696237500084699f1
😎 Deploy Preview https://deploy-preview-1953--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit af55c33
🔍 Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/66409a1044698f0008032378
😎 Deploy Preview https://deploy-preview-1953--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Narigo Narigo mentioned this pull request May 3, 2024
7 tasks
@Narigo Narigo mentioned this pull request May 3, 2024
Signed-off-by: Joern Bernhardt <joern.bernhardt@googlemail.com>
Copy link
Collaborator

@lowsky lowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it @Narigo !

@lowsky lowsky merged commit d529a95 into main May 12, 2024
5 checks passed
@lowsky lowsky deleted the fix-test-for-underscore-participants branch May 12, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants