This repository has been archived by the owner on Nov 23, 2018. It is now read-only.
Update file download logic to support checked in copies. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past image URLs have proven to be pretty unstable. With this change images can be checked so that they aren't repeatedly downloaded if already available in the repo. Also unifies download logic between sponsors and other images that was duplicated for no very good reason.
lukaszklis
approved these changes
Nov 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PR depends on #13)
In the past image URLs have proven to be pretty unstable. With this change images can be checked so that they aren't repeatedly downloaded if already available in the repo. Also unifies download logic between sponsors and other images that was duplicated for no very good reason.