Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modeling): undo-revert measureBoundingBox #973

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(modeling): undo-revert measureBoundingBox #973

wants to merge 2 commits into from

Conversation

hrgdavor
Copy link
Contributor

@hrgdavor hrgdavor commented Dec 29, 2021 •
edited

fix a bug in measureBoundingBox caused by mutating original boundingBox with transform

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

this fix also depends on #970 to be complete fix for #966

@hrgdavor hrgdavor requested a review from z3dev December 29, 2021 10:23
@hrgdavor hrgdavor mentioned this pull request Dec 29, 2021
Closed
3 tasks
@z3dev
Copy link
Member

z3dev commented Dec 29, 2021

@hrgdavor thanks for splitting this out.

does this fix the issue #966 ?
also, can you add the same tests for geom2 and path2? It would be good to verify those work as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z3dev z3dev Awaiting requested review from z3dev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hrgdavor @z3dev