Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed types for snap & generalize functions #1331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed types for snap & generalize functions #1331

wants to merge 2 commits into from

Conversation

iyegoroff
Copy link

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

js uses default exports so ts should use them too

z3dev
z3dev requested changes Apr 12, 2024
View reviewed changes
packages/modeling/src/operations/modifiers/snap.d.ts
export function snap(...geometries: RecursiveArray<Geometry>): Array<Geometry>
export default function snap<T extends Geometry>(geometry: T): T
export default function snap<T extends Geometry>(...geometries: RecursiveArray<T>): Array<T>
export default function snap(...geometries: RecursiveArray<Geometry>): Array<Geometry>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know what happens if the default is defined multiple times. I suggest reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z3dev z3dev z3dev requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iyegoroff @z3dev