Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme for Android 10 #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpiritCroc
Copy link
Contributor

Imported from my Substratum theme
https://github.com/SpiritCroc/DarkCroc-Android-theme

@luca020400
Copy link
Contributor

Thanks, last time I talked with Jorge he wanted the app to stay "white".
This forces the app to follow system theme, and I'm sure he would prefer a toggle for that instead.

@SpiritCroc
Copy link
Contributor Author

Right, adding a toggle shouldn't be hard, I can do that if @jruesga wants

@jruesga
Copy link
Owner

jruesga commented Apr 26, 2020

@SpiritCroc so sorry for so much delay to replay you.

TBH, I don't like to much Dark Themes in general, but if there is a good dark theme I won't opposite to merge it. Anyway, I tested your PR and I think there is still a lot of things to theme. This repo (https://github.com/Mazda--/rview/commits/master) contains more progress on top of your work, but I'm still feeling that, in both cases, many of the dark colours are not fitting properly in the screen (too really brighter and not matching with the background).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants