Stop hard-coding BUNDLE_GEMFILE when running wars #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davishmcclurg
commented
Oct 30, 2018
| @@ -297,18 +282,6 @@ protected String locateExecutable(final Object scriptingContainer, final CharSeq | |||
| } | |||
| } | |||
|
|
|||
| protected CharSequence executableScriptEnvPrefix() { | |||
| final String gemsDir = new File(extractRoot, "gems").getAbsolutePath(); | |||
| final String gemfile = new File(extractRoot, "Gemfile").getAbsolutePath(); | |||
There was a problem hiding this comment.
This is the main issue. Our project is using a custom gemfile (with BUNDLE_GEMFILE) and it's getting overridden here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.