Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[postgres] Fix dates when using non-standard format #1062

Open
wants to merge 1 commit into
base: 50-stable
Choose a base branch
from

Conversation

dr-itz
Copy link
Contributor

@dr-itz dr-itz commented Apr 25, 2020

Back-port from 52-stable

Date#to_s actually does the wrong thing when
Date::DATE_FORMATS[:default]
is set to something non-standard.

Fixes #1061

Back-port from 52-stable

Date#to_s actually does the wrong thing when
  Date::DATE_FORMATS[:default]
is set to something non-standard.

Fixes jruby#1061
@headius
Copy link
Member

headius commented Apr 29, 2020

I see some of these same suites failing on the 5.0 branch. Should they be green @enebo @kares @rdubya?

@enebo
Copy link
Member

enebo commented Apr 29, 2020

@headius those few errors have always been on 50 and 51. @dr-itz has actually fixed some but we have largely been just moving forward at this point. 5.0 and 5.1 of rails are technically no longer supported by Rails and we said we would not either (although I am still spinning releases of them when we backport).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants