Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare two graphs #87

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KasiaS999
Copy link

Description

This Pull Request introduces a new feature to compare two graphs with identical structures. The added functionality allows users to analyze differences in performance metrics, such as time or function calls, between two graphs generated from profiling data.

Changes Made

  • Implemented the option to compare two graphs in the --compare functionality.
  • Ensured that the comparison feature works accurately for graphs with the same structure (pstats and callgrind).

Additional Notes

  • Any feedback or suggestions for improvement are welcome.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 91 lines in your changes are missing coverage. Please review.

Project coverage is 83.71%. Comparing base (14e0d54) to head (5892fcf).

❗ Current head 5892fcf differs from pull request most recent head cf78a30. Consider uploading reports for the commit cf78a30 to get more accurate results

Files Patch % Lines
gprof2dot.py 18.75% 91 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   86.89%   83.71%   -3.19%     
==========================================
  Files           1        1              
  Lines        2290     2334      +44     
==========================================
- Hits         1990     1954      -36     
- Misses        300      380      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jrfonseca jrfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks ok.

Requiring exact same structure is an annoying limitation -- for example, for sampling profilers, graphs can easily change. But this is a step forward nevertheless. A simple solution to this would be to insert the missing nodes/edges with zero weight to ensure graphs are the same.

README.md Outdated Show resolved Hide resolved
gprof2dot.py Outdated Show resolved Hide resolved
gprof2dot.py Outdated Show resolved Hide resolved
@jrfonseca
Copy link
Owner

Also, we should add some test coverage for this, to ensure this doesn't break.

@KasiaS999
Copy link
Author

I added some tests (not sure if satisfying) and resolved tasks from you. When it comes to not requiring exact same structure I will try to tackle this in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants