correctly merges dataCenterInfo.metadata. fixes #144 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielsan Just curious, what value were you trying to set? This seems like it would only be a problem if you were trying to override a value coming in from the AWS metadata. Usually we treat the AWS metadata as the source of truth, hence the ordering here. |
|
I'm running applications inside Docker containers with the network configured as NAT, thus they get different IPs from the host, so when the AWS info comes back the IP address is not the one we need to register in Eureka |
|
I'm actually using my fork as the dependency right now. |
|
Is it possible to merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variable metadataResult containing the default values was overwriting all the custom values provided by the user, making the custom values useless.
The issue was fixed by changing the order of the arguments passed to the merge function.